galkahana / HummusJS

Node.js module for high performance creation, modification and parsing of PDF files and streams

http://www.pdfhummus.com

Other

1.15k stars 169 forks source link

Pre-built binaries for Electron 3 #344

Open rbeeger opened 5 years ago

rbeeger commented 5 years ago

Please add pre-built binaries for Electron 3.

galkahana commented 5 years ago

cheers.

hhaidar commented 5 years ago

I've opened a PR for this.

@galkahana electron v4 is coming out soon too, it might make sense to drop support for v1.

galkahana commented 5 years ago

@hhaidar let's drop 1 once 4 gets out. makes sense?

hhaidar commented 5 years ago

@galkahana for sure!

...and it looks like my build is failing :<

/home/travis/.nvm/versions/node/v10.2.0/bin/node: symbol lookup error: /home/travis/build/galkahana/HummusJS/binding/hummus.node: undefined symbol: _ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorE
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

this might not be as easy I thought haha

galkahana commented 5 years ago

yeah. this is the error i saw on linux/mac. see here - https://travis-ci.org/galkahana/HummusJS/builds/456039328 - in allowed failures.

the windows one goes ok - https://ci.appveyor.com/project/galkahana/hummusjs/builds/20358304

julianhille commented 5 years ago

galkahana / HummusJS

Pre-built binaries for Electron 3 #344

410 might solve these