search

galkahana / HummusJS

Node.js module for high performance creation, modification and parsing of PDF files and streams
http://www.pdfhummus.com
Other
1.14k stars 169 forks source link

add electron 3 build #347

Closed hhaidar closed 5 years ago

hhaidar commented 5 years ago

Ref #344

galkahana commented 5 years ago

thanks man

rbeeger commented 5 years ago

Thanks.

BTW: I haven't looked to deeply into it, but node 10.2.0 has some serious problems with building native dependencies. So it might be safer to take node 10.2.1 here instead of 10.2.0. https://github.com/electron/electron/issues/14645

galkahana commented 5 years ago

maybe this is why it aint compiling correctly on linux/mac. cheers. i'll try this

galkahana commented 5 years ago

No. Aint helping. So for now i mobed it to allowed failures. Electron build on windows works, though. Ill push binary build soon. We can take care of unix/mac later.