getImageDimensions() doesn't work with buffer as a stream

[silexboy]

Hi. I'm trying to merge PDF and image files from S3 to a single PDF document using PDFRStreamForBuffer() and memory-streams package for the writer.

        const writer = new streams.WritableStream();
        const pdfWriter = hummus.createWriter(new hummus.PDFStreamForResponse(writer), {
           compress: false,
           log: '...'
        });

    const {Body: data} = await s3.getObject(...).promise();
        ...

    if (type === 'pdf') {
        pdfWriter.appendPDFPagesFromPDF(new hummus.PDFRStreamForBuffer(data)); // OK
    }
    else if (['jpg', 'jpeg', 'png'].includes(type)) {
        const stream = new hummus.PDFRStreamForBuffer(data);
        const dimensions = pdfWriter.getImageDimensions(stream);  // NOT OK
        ...

As you see, the similarly created stream is good because appendPDFPagesFromPDF() works good. The problem is that getImageDimensions() doesn't work with such stream (and works well with the same image as local file, so the image is also ok).

I would be happy if somebody advice what's wrong here.

[diegoolavarria]

@silexboy do you manage to do this task? I have to do exactly the same and I'm stuck with trying to add the images to the final pdf document

[goatandsheep]

and createImageXObjectFromJPG doesn't accept buffer either

[goatandsheep]

I've placed a bounty on this issue

[willy2dg]

@goatandsheep Could be enough by creating a getStreamImageDimensions method or allowing getImageDimensions to accept a stream ?

[goatandsheep]

@willy2dg I do want createImageXObjectFromJPG to accept buffer, but the bounty is just for getImageDimensions so yes.

[willy2dg]

Ok @goatandsheep , I will be checking it . Anyways createImageXObjectFromJPG seems to be accepting a stream as input.

[willy2dg]

@goatandsheep I sent a PR. The steps to run it are the following :

• Clone repo
• In repo folder, run npm install --build-from-source
• In repo folder, run npm link ( create npm link to package )
• In your project folder, run npm link hummus ( link local package instad of installing from npm )

[goatandsheep]

Weird: npm install --build-from-source gave me 165 warnings

[willy2dg]

I got warning too, but they was there before my changes.

[willy2dg]

@galkahana is this able to be merged ? @goatandsheep can we close the issue ?

[goatandsheep]

@willy2dg I want the PR to be merged before we can close the issue. @galkahana I setup a ticket to figure out what to do re Travis issues (see link in PR)

[goatandsheep]

Hi @silexboy can we close the issue? The PR is green and will be merged as soon as @galkahana sees it. @willy2dg deserves the bounty.

[willy2dg]

The only activity in the @silexboy account is to open this issue, so I doubt it responds. @galkahana could you close this ?

[galkahana]

Is this ok?

[willy2dg]

Yes, thanks @galkahana . @goatandsheep I sent a bounty claim, please accept it when possible.

[galkahana]

Merged the pr too

[galkahana]

published as 106