search

galkahana / HummusJS

Node.js module for high performance creation, modification and parsing of PDF files and streams
http://www.pdfhummus.com
Other
1.14k stars 169 forks source link

add initial typescript typings #365

Closed moshensky closed 5 years ago

moshensky commented 5 years ago

Most of the credit for the typings should go to @jsgoupil. I have slightly enhanced typings based on my needs more then a year ago. Relevant issue: https://github.com/galkahana/HummusJS/issues/107

jsgoupil commented 5 years ago

Thanks for the credit! I'm happy it helped on the contribution.

galkahana commented 5 years ago

thanks @moshensky and @jsgoupil. Tests failures are not on account of your work. rather it's electron-mocha upgrade that screwed things up. Let's do this :).

galkahana commented 5 years ago

published as 1.0.97

moshensky commented 5 years ago

@galkahana I have installed 1.0.97, but the changes are not reflected. package.json is without the needed prop and the .d.ts file is missing too.

galkahana commented 5 years ago

probably cause it's not in the package.json files entry

galkahana commented 5 years ago

the types prop is in there, it's the file that's not. so i'll prep another build with the corrected files entry

galkahana commented 5 years ago

ok. 1.0.98 is now published. seems like the types connectivity is working well. thank you.

galkahana commented 5 years ago

All thanks goes to these guys ;).

Must say that now that i'm seeing the result it is quite motivating. it's really helpful. going forward i'll try to add to it.

tolotrasamuel commented 4 years ago

I am using "hummus": "^1.0.105" from npm install --save hummus but I do not see the type definition