search

galkahana / HummusJS

Node.js module for high performance creation, modification and parsing of PDF files and streams
http://www.pdfhummus.com
Other
1.15k stars 170 forks source link

electron prebuilts missing for version 1.0.104 #403

Closed rbeeger closed 5 years ago

rbeeger commented 5 years ago

I decided to just ignore the fact that no prebuilts are created for linux with electron 4 and 5 and started to migrate our project to electron 4.2.5 on macOS. While rebuilding the native dependencies node-pre-gyp complained that there is no https://hummus.s3-us-west-2.amazonaws.com/hummus/v1.0.104/electron-v4.2-darwin-x64-unknown.tar.gz . Other than for normal node builds node-pre-gyp doesn't use the ABI version for electron builds. It uses the minor version number for electron builds. To have prebuilts for all currently supported electron versions builds for 5.0.5, 4.2.6, 4.1.5, 4.0.8, 3.1.11, 3.0.16 would be needed.

Currently builds for electron 3.0.10, 4.1.5 and 5.0.0 are configured and https://hummus.s3-us-west-2.amazonaws.com/hummus/v1.0.104/electron-v3.0-darwin-x64-unknown.tar.gz is available, but there is no https://hummus.s3-us-west-2.amazonaws.com/hummus/v1.0.104/electron-v4.1-darwin-x64-unknown.tar.gz and also no https://hummus.s3-us-west-2.amazonaws.com/hummus/v1.0.104/electron-v5.0-darwin-x64-unknown.tar.gz . But the builds all look fine https://travis-ci.org/galkahana/HummusJS/builds/530482402 . The node-pre-gyp output in the travis logs always contains the same error, that doesn't seem to affect the creation of prebuilts for electron 1.8 and 3.0. So there is no way to see what it created and what it attempted to upload and why it doesn't work for electron 4.1 and 5.0.

rbeeger commented 5 years ago

This is fixed with version 1.0.105.