search

galkahana / HummusJS

Node.js module for high performance creation, modification and parsing of PDF files and streams
http://www.pdfhummus.com
Other
1.14k stars 169 forks source link

Added support for image stream on PDFWriter::getImageDimensions #430

Closed willy2dg closed 4 years ago

willy2dg commented 4 years ago

PR to solve #354

Adds implementation to accept a stream as getImageDimensions parameter and includes required internal methods to acomplish it.

JPEGImageHandler::RetrieveImageInformation using stream as parameter DocumentContext::GetImageType using stream as parameter

willy2dg commented 4 years ago

Hi @galkahana , seems Travis failed to prepare enviroment for NodeJS 11, but the issue is not related to the PR. Is there some way i can fix it ? Or i am forced to commit something to run Travis again ?

goatandsheep commented 4 years ago

The 502 Bad Gateway seems to be an unresolved issue on the Travis end

goatandsheep commented 4 years ago

@willy2dg can you please expand to Travis-CI on the related ticket

willy2dg commented 4 years ago

@goatandsheep , the ticket link is broken. Anyway, the error seems to have happened when downloading a dependency for the test environment, server responded with 502, so that an "empty commit" would probably pass the tests successfully.

goatandsheep commented 4 years ago

@willy2dg I have verified your fork builds successfully. I recommend you push an empty commit just to get the green checkbox. @galkahana please take a look when possible.

galkahana commented 4 years ago

published as 106