galki / material-ui-form

State and validation support for Material-UI form components
MIT License
11 stars 3 forks source link

updated code for method, action, name and id for form tag #58

Closed voletiswaroop closed 6 years ago

voletiswaroop commented 6 years ago

This Module enables the adding method, action, name, and id for the form tag

codecov-io commented 6 years ago

Codecov Report

Merging #58 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #58   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files          16       16           
  Lines         335      335           
  Branches       96       96           
=======================================
  Hits          216      216           
  Misses         87       87           
  Partials       32       32
Impacted Files Coverage Δ
src/components/Form.js 35.25% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81376ed...bbe59d9. Read the comment docs.

galki commented 6 years ago

@voletiswaroop are you ready to merge?

voletiswaroop commented 6 years ago

Yes, I'm ready to merge @galki. I have done the changes only in 'src/components/Form.js' file after the build the code updated in respective places

voletiswaroop commented 6 years ago

Hi @galki,

Due to the urgency in my current project, I have extended this module with above fix and published it to NPM.

Note: I have mentioned in my npm module "This project is an extended version of https://github.com/unitedhubs/material-ui-form/".

Let me know if anything?

galki commented 6 years ago

@voletiswaroop I'm sorry to have made you wait again. I have just started switching to Angular. Would you like to take over maintenance?

voletiswaroop commented 6 years ago

Apologies for the delay in response, Yes ill take it forward for maintenance. @galki