gallantlab / cottoncandy

sugar for s3
http://gallantlab.github.io/cottoncandy/
BSD 2-Clause "Simplified" License
33 stars 16 forks source link

MNT use github actions for continuous integration #84

Closed TomDLT closed 2 years ago

TomDLT commented 2 years ago

Fixes #81 Also fixes #79 and closes #82

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (a53f544) into main (43381a8) will decrease coverage by 18.70%. The diff coverage is 95.83%.

@@             Coverage Diff             @@
##             main      #84       +/-   ##
===========================================
- Coverage   58.85%   40.15%   -18.71%     
===========================================
  Files          11       15        +4     
  Lines        1541     2209      +668     
===========================================
- Hits          907      887       -20     
- Misses        634     1322      +688     
Impacted Files Coverage Δ
cottoncandy/tests/test_roundtrip_big.py 84.61% <75.00%> (-4.58%) :arrow_down:
cottoncandy/interfaces.py 58.99% <100.00%> (+0.38%) :arrow_up:
cottoncandy/tests/conftest.py 100.00% <100.00%> (ø)
cottoncandy/tests/test_compression.py 100.00% <100.00%> (ø)
cottoncandy/tests/test_roundtrip.py 100.00% <100.00%> (ø)
cottoncandy/Encryption.py 0.00% <0.00%> (ø)
cottoncandy/gdriveclient.py 0.00% <0.00%> (ø)
setup.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43381a8...a53f544. Read the comment docs.

TomDLT commented 2 years ago

Note that the tests are passing, the failure comes from codecov not getting the correct coverage (only 7%).

TomDLT commented 2 years ago

Codecov is no more at 7%, but it is only at 40%, because some new code (encryption, googledrive client) is not tested at all (report).

anwarnunez commented 2 years ago

Codecov gives a "failure" if the coverage decreases? That's rather forceful. If things are running, I say merge it into main.