gallantlab / himalaya

Multiple-target linear models - CPU/GPU
https://gallantlab.github.io/himalaya
BSD 3-Clause "New" or "Revised" License
80 stars 13 forks source link

FIX update of alphas when local_alpha=False for `solve_multiple_kernel_ridge_random_search` #24

Closed mvdoc closed 2 years ago

mvdoc commented 2 years ago

Without this fix, the targets were still updated individually even though the best alpha was selected based on the cv score averaged across targets.

This PR also adds a test to make sure that if local_alpha=False, then we get only a single alpha across all targets.

TomDLT commented 2 years ago

Very nice !