MNT Remove dependency on distutils

gallantlab / pycortex

Pycortex is a python-based toolkit for surface visualization of fMRI data

https://gallantlab.github.io/pycortex

BSD 2-Clause "Simplified" License

581 stars 137 forks source link

Closed kroq-gar78 closed 1 week ago

kroq-gar78 commented 1 week ago

This should remove any explicit mentions of distutils and fix installation in Python 3.12.

I'm not super familiar with the packaging system, so there's 2 things I'm not sure about:

Does anything else need to be done to address #538 ?
Does setuptools still need to be pinned to <60.0 ? It looks like this was done to fix #552, but the NumPy migration docs suggest this is only if you're using numpy.distutils (which this PR removes).

mvdoc commented 1 week ago

This looks great! Re your questions:

We should just add python 3.12 to the github actions and see whether the tests run
I don't think we'll need to pin setuptools anymore after removing numpy.distutils

mvdoc commented 1 week ago

I triggered the test on python 3.12, let's see

mvdoc commented 1 week ago

Alright, everything is green. I tried installing locally with a new conda environment and it works great. I'll merge and release a new version.

Thanks @kroq-gar78 !