search

gallantlab / pyrcca

Regularized kernel canonical correlation analysis in Python
Other
242 stars 73 forks source link

MNT move code from __init__ to rcca.py, fix Gaussian kernel, add requirements.txt, format code #22

Closed robinthibaut closed 3 years ago

robinthibaut commented 3 years ago

Hello there, I modified the code to solve the issue #16, and did some refactoring. I don't think the main code should be in an init file, so I separated the two in "rcca.py" and "init.py". I specified an "all" in rcca.py, so that classes can be imported easily. I also added a requirement file.

robinthibaut commented 3 years ago

Hello, I fixed the remaining issues. In the future I'll submit PR one by one as suggested. Kind regards, Robin

TomDLT commented 3 years ago

Thanks !