search

gallantlab / pyrcca

Regularized kernel canonical correlation analysis in Python
Other
241 stars 73 forks source link

possible bug in the code? #3

Closed franciscoaraposo closed 6 years ago

franciscoaraposo commented 7 years ago

Hi,

I've been studying your code and I found that there might be a bug. When you're filling in the left and right sides of the eigenvalue problem, you're trying to build the matrices that are shown in equation 7 of your arXiv version of the paper (https://arxiv.org/pdf/1503.01538.pdf), correct? If so, then it seems you are switching KxKy with KyKx (sorry but I don't know how to render math symbols here). Can you confirm this?

Thanks in advance, Francisco

jackgallant commented 7 years ago

Hi Francisco -

Thanks we will check into this.

Jack

On 09/05/2017 09:55 PM, franciscoaraposo wrote:

Hi,

I've been studying your code and I found that there might be a bug. When you're filling in the left and right sides of the eigenvalue problem, you're trying to build the matrices that are shown in equation 7 of your arXiv version of the paper (https://arxiv.org/pdf/1503.01538.pdf), correct? If so, then it seems you are switching KxKy with KyKx (sorry but I don't know how to render math symbols here). Can you confirm this?

Thanks in advance, Francisco

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gallantlab/pyrcca/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ5S_8YbyTnM-L5ZGxvqyq1ocYMGMItoks5sfiXdgaJpZM4PN1vg.

--

Jack Gallant Chancellor's Professor of Psychology Programs in Neuroscience, Computer Science, Bioengineering, Biophysics & Vision Science University of California at Berkeley web site: http://gallantlab.org twitter: @gallantlab

"Don't undertake a project unless it is manifestly important and nearly impossible." -- Edwin Land

polosecki commented 6 years ago

Hi, I am starting to experiment with pyrcca (congratulations on the cool tool!), and I am curious as to this bug is confirmed or not. Thanks! Pablo

nbilenko commented 6 years ago

Hi Francisco,

Thank you for catching this and apologies for the delayed response. This was indeed a bug. Should be fixed now via a9b05c040f3cd292bf160587529d03ffda4e4044.

Best, Natalia