galliot-us / neuralet

Neuralet is an open-source platform for edge deep learning models on edge TPU, Jetson Nano, and more.
https://neuralet.com
Apache License 2.0
238 stars 71 forks source link

Face mask classifier #68

Closed mrn-mln closed 4 years ago

mrn-mln commented 4 years ago

47 Create a classifier for face/mask problem.

mhejrati commented 4 years ago

Thanks @mrn-mln for this. I will review it.

mhejrati commented 4 years ago

@alpha-carinae29 can you please help review this PR?

mrn-mln commented 4 years ago

@alpha-carinae29 Thanks for reviewing, I applied some of your comments.

mhejrati commented 4 years ago

@mrn-mln I just reviewed this PR. Feedback: 1- Can you please remove all the images and instead use a script to download what you need from the original source? This is cleaner in terms of making it clear for the user where those images came from, and also will not bloat the repo. 2- Can you please delete the results images and provide a script that if the user runs will generate the images? 3- We are in the process of moving this application to another repo, https://github.com/neuralet/smart-social-distancing, I will close this PR here without merging. Can you please submit a PR to the other repo with the change requested above (removing the images).

Many thanks for this awesome contribution :)

mrn-mln commented 4 years ago

@mhejrati yes, I will do it.