search

gallowaylabs / streamdeck-tomato-timer

A configurable timer for balancing work and break times
MIT License
19 stars 1 forks source link

"Click to play" button doesn't work until initial volume adjustment #5

Closed vghougassian closed 1 year ago

vghougassian commented 1 year ago

This is a mild inconvenience if anything, but took a few minutes to figure out as a new user; it's not deal-breaking in any way.

When a new actions is created, the Alarm Volume slider on the UI is set to 100 by default. Even if the Alarm Sound option is changed from None to one of the available sounds, the "Click to play" button won't work until the Alarm Volume is adjusted away from its initial position.

To reproduce:

  1. Drag a new timer onto a button
  2. Select an Alarm Sound that isn't None
  3. Press "Click to play" button (nothing happens) <-- this is the issue
  4. Slide Alarm Volume slider to any position other than 100 <-- this is the workaround
  5. Press "Click to play" button (button toggles to "Click to stop" and sound plays)
  6. Slide Alarm Volume slider back to 100
  7. Press "Click to play" button (button toggles to "Click to stop" and sound plays)

It seems that when a new action is created, the "Settings" object for the action is empty: { "ActionID": "ba0a9a95-9528-4f7b-9238-a52f39474837", "Name": "Timer", "Settings": {}, "State": 0, "States": [ {} ], "UUID": "com.gallowaylabs.tomato.clock" }

After the value of the slider has changed, the "Settings" object is populated with an "alarm_volume" key: { "ActionID": "ba0a9a95-9528-4f7b-9238-a52f39474837", "Name": "Timer", "Settings": { "alarm_volume": 1 }, "State": 0, "States": [ {} ], "UUID": "com.gallowaylabs.tomato.clock" }

Possibly the same issue as the one reported in issue #2

mgway commented 1 year ago

Fascinating, I'm unable to replicate this issue right now. Even on a brand new profile after restarting the stream deck application, setting the sound to 'digital' and clicking the play button works on the first try.

On second thought, this was fixed in https://github.com/gallowaylabs/streamdeck-tomato-timer/commit/8988d9d9a60b9cd574f4598c7ab8b6572dc836d2, I just neglected to submit it to the Streamdeck store. It will be in the v0.5.0 which is currently pending release in the store.

vghougassian commented 1 year ago

Ah, in fairness, I should have checked the changelog; much appreciated.