galnir / Master-Bot

A Discord music bot and dashboard with slash commands, playlist support, Spotify, music quiz, saved playlists, lyrics, gifs and more
MIT License
465 stars 372 forks source link

add-role.js and rmv-role.js change suggestions #503

Closed Natemo2625 closed 3 years ago

Natemo2625 commented 3 years ago

Explain your suggestion Currently they don't work with user/role id or name, so maybe make it where you don't have to mention the user or role? If you think it's a good idea I can do it, but since I don't have the time right now, I thought I'd get some opinions.

galnir commented 3 years ago

I'll look into it. My intention was that it would work with user/role id and names

Bacon-Fixation commented 3 years ago

check out #520

I had some spare time, I hope you don't mind Galnir. I leveraged discordjs-commando's "member" and "role" flags for the arguments.

Much Love -Bacon

Bacon-Fixation commented 3 years ago

@Natemo6348 thank you for the suggestion checkout the latest commit (ea644d5)

allows for the use of the (Name, Mention, or ID) to add or remove a role

Examples
!ar bacon muted
!rr Bacon#**** <role-id>
!ar <user-id> <mention-role>
etc...

if you have any other suggestions don't hesitate to open another enhancement page with suggestions <3

Much Love -Bacon