Patch - Commands not working in DM

galnir / Master-Bot

A Discord music bot and dashboard with slash commands, playlist support, Spotify, music quiz, saved playlists, lyrics, gifs and more

MIT License

464 stars 373 forks source link

Patch - Commands not working in DM #775

Closed Bacon-Fixation closed 1 year ago

Bacon-Fixation commented 1 year ago

Added the following to IsCommandDisabled.ts before the const data trcp query

    if (!interaction.guildId && interaction.user.id) {
      return this.ok();
    }

Testing

[x] Allows commands to work in DMs
[x] still able to enable/disable commands per guild
[x] /play and other guild only commands provide a message informing the user that the command is guild only

Much Love -Bacon

galnir commented 1 year ago

What happens if the user's DM is closed? Does it throw an error or something?

Bacon-Fixation commented 1 year ago

That's a good point, I didn't test for that, I will double check what happens , but if the user sends a DM with DMs disabled, I think it would go through, as the user has to initiate the DM, instead of the bot making a dm channel, I will test later on today and make alterations if needed, in the meantime I will move it to a draft

Much Love -Bacon

Bacon-Fixation commented 1 year ago

Was able to test what happens remotely, it responds with an error message

Much Love -Bacon