inconsistent naming and no longer exists icon

galonsos / line_icons

Flutter class for Awesome Line Icons

GNU General Public License v3.0

73 stars 10 forks source link

inconsistent naming and no longer exists icon #24

Closed calvintam236 closed 1 year ago

calvintam236 commented 3 years ago

For example, per Icons8:

inconsistent naming
- store-alt -> alternateStore
- hospital-alt -> hospitalAlt
no longer exists
- buildingAlt (building-1 no longer exists)

There are more than I shown here.

I think latest version of this package should always has the current icons set, and icon(s) removed should not be supported by adding @Deprecated tag.

mathtasatlime commented 2 years ago

This is also a hugh problem for me! Pls fix it!

lukehutch commented 1 year ago

I agree it would be much better to exactly follow the naming given on the Line Awesome website. Putting alternate at the beginning rather than using -alt as a suffix is an unnecessary change.

galonsos commented 1 year ago

Three points here:

Naming has to follow Dart/Flutter conventions (whatever-alt becomes whateverAlt).
The naming was already given automatically, so inconsistency doesn't come from me, but from the metadata included in the font itself.
The package is not regularly mantained, as you may notice :). I made it for my own projects and published it, but that's all. That means I'm not closely watching changes on the original Line Awesome site and the package doesn't reflect the latest version of Line Awesome icon set.

That said, I'll take into account your suggestiones for any future update. Thank you, guys!

lukehutch commented 1 year ago

@galonsos But the point is you didn't follow the pattern in the original library: whatever-alt is not whateverAlt, you made it into alternateWhatever...

whateverAlt is fine, but alternateWhatever makes it very hard to find icons via autocomplete sometimes, because that name doesn't even start with the same letter as the official icon name.