search

galou / freecad.cross

CROSS CAD and ROS, an Open-Source Synergy; ROS workbench for FreeCAD
GNU Lesser General Public License v2.1
95 stars 26 forks source link

fix Set Placement with Link and one LCS #23

Closed sprhawk closed 2 months ago

sprhawk commented 8 months ago

fix Set Placement:

Select one Link and LCS and other

sprhawk commented 8 months ago

Should this change be MountedPlacement or Placement ?

galou commented 8 months ago

MountedPlacement is a fixed property of a link whereas Placement is the placement relative to the robot and gets recalculated e.g. when the joint values are changed in the robot.

Can you give an minimal example to test your change. Please, at best, in Python code. You can generate Python code with ObjectsToPython.FCMacro.

sprhawk commented 8 months ago

MountedPlacement is a fixed property of a link whereas Placement is the placement relative to the robot and gets recalculated e.g. when the joint values are changed in the robot.

Can you give an minimal example to test your change. Please, at best, in Python code. You can generate Python code with ObjectsToPython.FCMacro.

Actually I'm not sure it should be changed, but in original code, when I Set Placement, it didn't change link's placement.

drfenixion commented 6 months ago

I dont think it should be changed because tool works as expected. Just usage of tool is sophisticated. You can check my tips for this tool and also doc.

https://github.com/galou/freecad.cross/issues/32#issuecomment-2002927203 https://github.com/galou/freecad.cross/wiki/Command-SetPlacement