search

galsci / pysm

PySM 3: Sky emission simulations for Cosmic Microwave Background experiments
https://pysm3.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
33 stars 23 forks source link

GNILC modulation with local spectra #150

Closed zonca closed 1 year ago

zonca commented 1 year ago

Implementation of https://github.com/galsci/pysm/issues/148

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

yaojian95 commented 1 year ago

Hi Andrea, I have installed the latest pysm main branch and run the test and found following errors. Most of them are due to the reading permission error of synch_template_nside2048.fits(I think you are working on this) , one of the error is due to that I haven't installed the pixell which is used in the pysm3/tests/test_smoothing.py.

==================================================================================== short test summary info ===================================================================================== FAILED pysm3/tests/test_max_nside.py::test_sky_max_nside_highres - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_smoothing.py::test_car_nosmoothing - AttributeError: 'NoneType' object has no attribute 'enmap' FAILED pysm3/tests/test_synch_pysm3.py::test_synch_model_s7_noscaling[s7] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_synch_pysm3.py::test_synch_model_s7_44[s7] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_synch_pysm3.py::test_synch_model_noscaling[s4] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_synch_pysm3.py::test_synch_model_noscaling[s5] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_synch_pysm3.py::test_synch_44[s4] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_synch_pysm3.py::test_synch_44[s5] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_synch_pysm3.py::test_s6_vs_s5[23] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' FAILED pysm3/tests/test_synch_pysm3.py::test_s6_vs_s5[44] - PermissionError: [Errno 13] Permission denied: '/global/project/projectdirs/cmb/www/pysm-data/synch/synch_template_nside2048.fits' =============================================================== 10 failed, 95 passed, 2 skipped, 15 warnings in 3199.07s (0:53:19) ===============================================================

zonca commented 1 year ago

thanks @yaojian95, can you please test again now?

yaojian95 commented 1 year ago

Yeah I confirm that all the tests past with the latest pysm3, and with pixell installed.