galsci / pysm

PySM 3: Sky emission simulations for Cosmic Microwave Background experiments
https://pysm3.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
36 stars 23 forks source link

Include Agora kSZ and tSZ components #181

Open zonca opened 6 months ago

zonca commented 6 months ago

First it would be useful to make a test creating a custom PySM component with a configuration file: https://pysm3.readthedocs.io/en/latest/customize_components.html

Replacing websky maps with Agora unlensed maps from https://yomori.github.io/agora/index.html

Create a notebook that does a comparison between the 2, post it on https://gist.github.com/ and link it here. Then we will decide what to do next.

kmsurrao commented 4 months ago

Here is a link to a notebook comparing Agora tSZ and kSZ to WebSky: https://gist.github.com/kmsurrao/4a938ff439f8c45bfae1c9b50f87455b. I had to change a couple things in the pysm source code to get custom config files working properly. Specifically, in sky.py I removed line 23 for model_name, model_config in config.items():, and replaced model_configwith config for all the lines that were previously inside that loop.

zonca commented 4 months ago

thanks @kmsurrao, can you also share the implementation of AgoraSZ? the easiest thing is probably to make a pull request to PySM, so we can easily spot the differences.

kmsurrao commented 4 months ago

I made a pull request for the changes in sky.py. For the AgoraSZ, right now I'm reading files locally. Should I make a pull request for that as is, or change it to read the files from somewhere remote?

zonca commented 4 months ago

For now, just as it is is fine then I will provide feedback on how to make it compatible with the rest of pysm

kmsurrao commented 4 months ago

I just updated the previous pull request