search

galsci / pysm

PySM 3: Sky emission simulations for Cosmic Microwave Background experiments
https://pysm3.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
36 stars 23 forks source link

Remove pixell sharp dependency #183

Closed msyriac closed 3 months ago

msyriac commented 5 months ago

This fixes #178

zonca commented 5 months ago

@msyriac feel free to update minimum python in Github Action or notify me to take care of that

msyriac commented 5 months ago

I have now, but there seems to be a numpy related error. I might not have time to look into this until next week!

itrharrison commented 5 months ago

I think the problem is that pixell's setup.py imports various numpy things but that requirement isn't satisfied when the setup gets run.

Adding numpy to the pysm install_requires seems to fix (but ofc I can't push to Mat's fork).

zonca commented 5 months ago

@itrharrison if you'd like to open another PR and fix this it would be much appreciated!

zonca commented 5 months ago

@itrharrison do you have a branch where you tested this?

itrharrison commented 5 months ago

No, sorry, I have been trying but no matter where I add numpy the same problem appears. You can see here: https://github.com/itrharrison/pysm/pull/1/files

I guess the other option would be for pixell to remove the numpy imports from its setup.py

zonca commented 5 months ago

Thank you very much for your help with this. I was wondering, is it possible this has something to do with numpy 2.0? Does it make a difference if we set to avoid numpy.2?

zonca commented 5 months ago

@itrharrison maybe we should open a PR on pixell implementing this? @msyriac? https://stackoverflow.com/questions/19919905/how-to-bootstrap-numpy-installation-in-setup-py

zonca commented 5 months ago

my hope is that putting numpy in setup_requires on pixell fixes this issue

zonca commented 5 months ago

@itrharrison would you like to create a branch of pixell with this fix, then setup Github Actions in your branch of PySM to install pixell from that git branch and see if everything magically works (I know I'm an optimist!). If so, we (meaning you of course) can then contribute this fix to pixell.