search

galsci / pysm

PySM 3: Sky emission simulations for Cosmic Microwave Background experiments
https://pysm3.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
36 stars 23 forks source link

ImportError for importlib_resources in python 3.6 #58

Closed dpole closed 4 years ago

dpole commented 4 years ago

Apparently importlib_resources doesn't get installed in python 3.6 but seems to be required. Is it something to be fixed in the install process or is it a problem on my side?

zonca commented 4 years ago

Are you installing with pip from PyPI?

On Mon, Jun 22, 2020, 03:27 Davide Poletti notifications@github.com wrote:

Apparently importlib_resources doesn't get installed in python 3.6 but seems to be required. Is it something to be fixed in the install process or is it a problem on my side?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/healpy/pysm/issues/58, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5Q4SSYT3WYJIMBCU6XLTRX4W2NANCNFSM4OEOJDRQ .

dpole commented 4 years ago

No. I install it as a dependency of another library, cloning the master branch of the github repo: pysm3 @ git+http://github.com/healpy/pysm.git@master#egg=pysm in the install_requires of my setup.py

zonca commented 4 years ago

I would recommend to use published releases on PyPI. Master could be broken from time to time. Can you check if this happens also installing from PyPI?

dpole commented 4 years ago

Yes, it worked. I think I used to need the dev version but it doesn't seem to be the case anymore. thanks.

zonca commented 4 years ago

great news!

On Mon, Jun 22, 2020 at 8:22 AM Davide Poletti notifications@github.com wrote:

Closed #58 https://github.com/healpy/pysm/issues/58.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/healpy/pysm/issues/58#event-3468901943, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5Q4Q5XN526CJVAC2XDHDRX5ZKNANCNFSM4OEOJDRQ .

dpole commented 4 years ago

I realized that I didn't remove my workaround (importlib_resources in addition to pysm3 in my install_requires). If I remove it, I still get an error from pysm.sky because import_resources doesn't get installed with pysm3. Any idea? Not urgent anyway

zonca commented 4 years ago

thanks @dpole, it was actually missing from the dependencies, I just released 3.2.2, can you please test it?

dpole commented 4 years ago

Yes, it now installs and runs smoothly. Thanks for the quick action