search

galsci / pysm

PySM 3: Sky emission simulations for Cosmic Microwave Background experiments
https://pysm3.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
36 stars 23 forks source link

Fix warnings in unit tests #88

Closed zonca closed 3 years ago

zonca commented 3 years ago

From JOSS review: https://github.com/openjournals/joss-reviews/issues/3783#issuecomment-932672403

Too many warnings that should be logs instead hide some useful warning. Cleanup the code to highlight the proper warnings and fix them.

zonca commented 3 years ago

Thanks @patricialarsen, it was very useful to cleanup the warnings, I found an actual bug hidden in there:

https://github.com/galsci/pysm/pull/88/commits/f6eaaf020fb107cec60ecab2d4608a4a28dbd7e7