Lessen use of getUserUrls

galtenberg / evernote-random

Use evernote API as a logged-in user - react and express project

Other

39 stars 6 forks source link

Lessen use of getUserUrls #14

Open galtenberg opened 6 years ago

galtenberg commented 6 years ago

Per Evernote API team:

Looking at our logs, I'm seeing an abnormal number of calls for getUserUrls - 380 calls for a single user. I'd recommend caching the result for a user, the result of that call is unlikely to ever change.

getUserUrls evernote doc: http://dev.evernote.com/doc/reference/UserStore.html#Fn_UserStore_getUserUrls

galtenberg commented 6 years ago

Likely called by getNoteStore() in the evernote library https://github.com/evernote/evernote-sdk-js/blob/master/src/client.js#L105-L110

What we can do is:

In server/controllers/notes.js have notebooks() and randomNote() functions accept a noteStoreUrl param - pass that into calls to client.getNoteStore(noteStoreUrl) (here and here)
If req.session.noteStoreUrl exists use it and pass it to those functions - otherwise call a function to obtain it, store it in the session