galterlibrary / InvenioRDM-at-NU

Next generation repository for health science
MIT License
9 stars 0 forks source link

Faceted searching in a certain order generates an error #389

Open carsonicator opened 5 years ago

carsonicator commented 5 years ago

Faceting by name works fine:

Screen Shot 2019-07-23 at 10 28 49 AM

Faceting by name and medical subjects works fine:

Screen Shot 2019-07-23 at 10 29 46 AM

Including a facet on ATP-binding cassette works:

Screen Shot 2019-07-23 at 10 30 41 AM

Turning off the name facet works:

Screen Shot 2019-07-23 at 10 31 52 AM

But if I add a name facet again I get an unnamed error:

Screen Shot 2019-07-23 at 10 33 18 AM
jpastva commented 5 years ago

A somewhat related suggestion - when selecting one facet, if the search results are automatically updated, perhaps the facet values should update based on the new results? Otherwise there's the impression results are available for that facet, when there may not be. (Looks like this is how Zenodo works currently, but I don't like it!)

fenekku commented 5 years ago

Haha! There is never a "right" answer for search user experience, but here are the 3 main factors in the decision to have other filters not update when one is selected:

1- Convention: Zenodo does it this way, so we do it this way. It keeps the experience the same. But Zenodo does it this way, because it tries to keep the same experience as other ElasticSearch backed faceting. ElasticSearch pushes this approach and it is how it does things. 2- ElasticSearch does it this way to combat loss of context: if clicking a single filter changes all the others, it is jarring and the user loses overview of options. Then if they want to go back (because of jarring effect or because of filter not working out), they have to move their cursor to the back button rather than stay in place to assess other options. 3- Much more effort to break the convention here.

jpastva commented 5 years ago

Fair enough, I'll get over it 🙂