galterlibrary / InvenioRDM-at-NU

Next generation repository for health science
MIT License
9 stars 0 forks source link

[#438] Fix (most) issues with terms on the record creation page #453

Closed fenekku closed 5 years ago

fenekku commented 5 years ago

To fix the deposit page, we had to revert our past changes to invenio-records-js and make different ones.

The real problem is that the ui-select (multiple option) library is buggy and unmaintained (~117 open issues): https://github.com/angular-ui/ui-select/issues?q=is%3Aissue+is%3Aopen+multiple&utf8=%E2%9C%93 . Additional bugs with ui-select multiple were uncovered when working on this issue which led us to abandon using ui-select multiple entirely. Instead, we

Closes #438

fenekku commented 5 years ago

This is somewhat big so ask me questions if things are unclear. I tried to place a lot of explainer comments to help.

NOTE: There is one edge case that is weird: adding multiple terms and deleting the first one gives strange results, but this is the best we are going to get from the ui-select library at this point. :face_with_head_bandage:

I will deploy this tomorrow morning (might be more issues on stage, but I will need more energy to deal with them).