search

galterlibrary / digital-repository

DigitalHub - Institutional Repository for Galter Health Sciences
https://digitalhub.northwestern.edu/
5 stars 1 forks source link

[#1027] Switch Publishing Order In Some Cases #1096

Closed Meowcenary closed 2 years ago

Meowcenary commented 2 years ago

Updates logic for exporting publisher so that Pediatric Neurology Briefs will use "Pediatric Neurology Briefs Publishers" instead of "Digital Hub" as the publisher. closes #1027

fenekku commented 2 years ago

Sorry, I am a little late to the party here. Just a quick follow-up question to @fenekku's comment:

It's better to have a publisher value always.

Has there been cases of no publishers? If so, then these changes won't solve that(if @generic_file.publisher.shift is nothing). We can move this into a new issue if necessary to keep the context separate.

This was in reference to former piece of code in PR that would check a criteria and if present, return the result of a find on another criteria. This could lead to exporting nil as publisher (even though there was a publisher). This is fixed now and we are all good.