search

galterlibrary / digital-repository

DigitalHub - Institutional Repository for Galter Health Sciences
https://digitalhub.northwestern.edu/
5 stars 1 forks source link

[#1133] Remove Edit Buttons From Collection and Generic File Views #1134

Closed Meowcenary closed 1 year ago

Meowcenary commented 1 year ago

Remove buttons that can change collections and generic files from all views. closes #1133

Meowcenary commented 1 year ago

This will be merged whenever we decide to close DigitalHub to editing.

sharpattack commented 1 year ago

@fenekku I think this is deployed to staging, right @Meowcenary?

Having some trouble with our dummy student netid(I think it's expired), but as myself, I can still visit /edit on any file and make changes. Can a normal user do the same?

Meowcenary commented 1 year ago

@fenekku I think this is deployed to staging, right @Meowcenary?

It is right now. I'll deploy again in case there were other updates that didn't make it.

Having some trouble with our dummy student netid(I think it's expired), but as myself, I can still visit /edit on any file and make changes. Can a normal user do the same?

I'll have to check my roles, but i'm logged in on staging and unable to edit or delete any of my files/collections or any other that I'm coming across.

carsonicator commented 1 year ago

@sharpattack were you using the gso1135 NetID? I will check with IT and reactivate if expired.

sharpattack commented 1 year ago

@carsonicator I am having trouble with both netids. I just opened a ticket with FSMIT and CC'd the galter-is email.

Meowcenary commented 1 year ago

I'm going to give myself more roles on staging to see if that reveals edit buttons I was not seeing previously. Maybe there's something like that going on here.

Meowcenary commented 1 year ago

Aha - batch editing buttons only appear after you've clicked a checkbox for a file. I was only looking at the actions dropdown for the files.

Edit: There's some more cleanup to be done so I'll keep plugging away at this as I have time. I'll aim to have this ready for re-review by Friday.

Meowcenary commented 1 year ago

Going to close this out now that #1117 has replaced #1133 .