search

galterlibrary / digital-repository

DigitalHub - Institutional Repository for Galter Health Sciences
https://digitalhub.northwestern.edu/
5 stars 1 forks source link

[#1132] Additional Organization Names #1138

Closed Meowcenary closed 1 year ago

Meowcenary commented 1 year ago

Fix organization names and types in memoized data. Switch format of memoized_person_or_org_data from text to json. closes #1132

Meowcenary commented 1 year ago

@fenekku - thanks for catching the mistakes! I'll start looking into fixing them.

Meowcenary commented 1 year ago

Okay, I updated the entry "Yang, Amy (Biostatistics Collaboration Center)" with this:

"person_or_org_data: {
  "name": "Biostatistics Collaboration Center",
  "type": "organizational"
}

And ran the file through a JSON validator here: https://jsonformatter.curiousconcept.com/

I'm going to check against another JSON validator to make extra certain there aren't duplicates.

Ran it through here: https://jsonlint.com/ also and even dropped in some duplicate keys to make sure it was catching those. I think this should be okay now.

As a quick reminder, I don't think it makes sense to keep relying on the known_organizations file since the organizations causing the issues are actually in that file so it's a deeper code issue. Entering things directly into the memoized file will resolve the issue without much fuss.