search

gama-platform / gama.old

Main repository for developing the 1.x versions of GAMA
GNU General Public License v3.0
304 stars 99 forks source link

Stats.java and Stats2.java have duplicate operators : need to consolidate #3265

Closed AlexisDrogoul closed 2 years ago

AlexisDrogoul commented 2 years ago

Following #3260 , looking at https://github.com/gama-platform/gama/blob/GAMA_1.8.2/ummisco.gaml.extensions.stats/src/ummisco/gaml/extensions/stats/Stats.java and https://github.com/gama-platform/gama/blob/GAMA_1.8.2/ummisco.gaml.extensions.stats/src/ummisco/gaml/extensions/stats/Stats2.java, one can see several duplicates (like kurtosis, variance, etc..). At runtime, it is impossible to tell which one will be picked. Not only can it cause confusion for modellers (as the documentation will change also !) but it can also introduce bugs as they rely on different libraries (Colt and Apache mostly).

These two classes should be merged and the duplicates removed.

AlexisDrogoul commented 2 years ago

Closing this now. Statistical operators have been merged, and no tests seem to be failing.