gama-platform / gama.old

Main repository for developing the 1.x versions of GAMA
GNU General Public License v3.0
304 stars 99 forks source link

Missing projects from some installed plugin in the model library #3886

Closed RoiArthurB closed 1 year ago

RoiArthurB commented 1 year ago

Describe the bug The plugin physics doesn't add models in the Plugin model folder after a new workspace initialization on Linux

To Reproduce Steps to reproduce the behavior:

  1. Install latest GAMA
  2. Create new workspace
  3. Wait for the initialization to finish
  4. See 13 projects instead of 14 on Plugin model folder

Expected behavior Have every plugin's demo model added in library

Screenshots

image

image

image

Desktop (please complete the following information):


EDIT : While manually copying Stairs.gaml model, it works perfectly fine, it's just the model library which is missing :/

Stairs_model_display_Climb_cycle_233262_time_1695289796556

AlexisDrogoul commented 1 year ago

When exploring Gama.app on macOS, I can see that the models folder inside Contents/Eclipse/plugins/simtools.gaml.extensions.physics_1.9.2.202309031322 is effectively empty. So it means that the problem occurred at compilation / assemblage time, while https://github.com/gama-platform/gama/tree/GAMA_1.9.2/simtools.gaml.extensions.physics/models/Physics%20Engine is obviously not...

RoiArthurB commented 1 year ago

But do you have the Physics folder in GAMA on MacOS ? Because, what's odd, is that it's missing on Linux but present on Windows 11... :thinking:

AlexisDrogoul commented 1 year ago

Missing on macOS too. models is empty in the plugin and so no models is copied in the workspace of GAMA.

hqnghi88 commented 1 year ago

You mean 1.9.2 release? i download withJDK_M1 and it is here with physics plugins, in a new GAMA workspace

Screenshot 2023-09-22 at 16 18 24
AlexisDrogoul commented 1 year ago

Absent from GAMA_1.9.2_MacOS_M1.dmg as you can see below.

plugins 2023-09-23 09-09-07

But present in the one with JDK ! See below:

Gama 1 9 2 with JDK app 2023-09-23 09-11-59

Thank you @hqnghi88, you nailed it !

@RoiArthurB it is definitely an "assemblage" problem during the compilation on GHA.

RoiArthurB commented 1 year ago

Make no sense, the jdk version is just a copy-pasted project (with add/modified file to embed JDK), so it shouldn't have any difference between versions for those files.

Also, this folder is properly filled after compilation for each os image

RoiArthurB commented 1 year ago

Tested and fixed on c2e0cc20 for Linux w/o JDK :)

plugins/simtools.gaml.extensions.physics_1.9.3.202309250401/models
└── Physics Engine
    ├── images
    │   ├── ball.jpg
    │   ├── bam.png
    │   ├── bang.png
    │   ├── basket.jpg
    │   ├── DEM
    │   │   ├── DEM.jpg
    │   │   ├── DEM.png
    │   │   ├── RedRiver.asc
    │   │   ├── Volcano DEM.asc
    │   │   ├── Volcano DEM.asc.aux.xml
    │   │   ├── Volcano DEM.prj
    │   │   └── Volcano Texture.jpg
    │   ├── foot.jpg
    │   ├── marble2.jpg
    │   ├── marble.jpg
    │   ├── mat.jpg
    │   ├── tennis.jpg
    │   └── wood.jpg
    └── models
        ├── Eroding Vulcano.gaml
        ├── Falling.gaml
        ├── Flow on Terrain.gaml
        ├── Perfect Gas Chamber.gaml
        ├── Play Pool.gaml
        ├── Stairs.gaml
        ├── Testing Restitution.gaml
        ├── Testing Steps.gaml
        └── Tricky Fountain.gaml

5 directories, 26 files