Store all necessary data in the Faraday connection cache key

gamache / hyperresource

A self-inflating Ruby client for hypermedia APIs. Not under active development.

http://hyperresource.com/doc

MIT License

304 stars 29 forks source link

Store all necessary data in the Faraday connection cache key #22

Closed fancyremarker closed 10 years ago

fancyremarker commented 10 years ago

Previously, the cache key consisted only of the resource's URL, even though the Faraday connection was instantiated with headers and Basic Auth values that might vary across HyperResource instances.

This should fix #21, but please let me know if you have a preferred way to serialized the headers and auth hashes.

fancyremarker commented 10 years ago

Whoops, original changes were 1.9+ only. Updated with 1.8 syntax.

gamache commented 10 years ago

Oh, good catch. This is great, thank you!