gamalan / caddy-tlsredis

Redis Storage using for Caddy TLS Data
Apache License 2.0
95 stars 31 forks source link

Internal struct fields should not be exported #43

Closed francislavoie closed 1 year ago

francislavoie commented 1 year ago

See https://github.com/gamalan/caddy-tlsredis/blob/66e1c61412decebb977790af25f7a6ce5c9b5878/storageredis.go#L120

These three fields should have lowercase names, because otherwise when adapting Caddyfile to JSON, they appear in the adapted config as null.

Essentially harmless, but it's a minor mistake. I'll open a PR at some point, just writing this down as a reminder.

Reported in https://caddy.community/t/need-help-with-certificate-creation-with-zerossl-and-caddy-using-redis-storage-module-connected-to-aws-elasticache/20464