stengel
commented
8 years ago Hi, Harkirat, thanks for this, but it breaks the original functionality - the circle size should have nothing to do with the information set height (which is GTE.CONSTANTS.ISET_HEIGHT and which we need, should later come from GTE.STORAGE), nor with the placement of the information set for that matter.
Leave it alone for a while - the whole code is not orthogonal, because settingsCircleSize pops up at many places where it shouldn't. I suspect this was because the node circles are not drawn by center but by lower left corner and then propagated wrongly through the code.
Regards, --Bernhard
- harkirat singh notifications@github.com [26-03-2016 07:57:47 -0700]:
Left an offset of (.05 * circle radius) at the top and bottom, Fixed y component. You can view, comment on, or merge this pull request online at:
https://github.com/gambitproject/jsgte/pull/75
-- Commit Summary --
- Fixes #74
-- File Changes --
M html/js/tree/ISet.js (6)-- Patch Links --
https://github.com/gambitproject/jsgte/pull/75.patch https://github.com/gambitproject/jsgte/pull/75.diff
You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/gambitproject/jsgte/pull/75
Prof Bernhard von Stengel email: stengel@nash.lse.ac.uk Department of Mathematics http://www.maths.lse.ac.uk/Personal/stengel London School of Economics phone: +44-20-7955 6438 (office) Houghton St, Room COL 4.12 +44-20-7226 2325 (home) London WC2A 2AE, United Kingdom
hkirat
Left an offset of (.05 * circle radius) at the top and bottom, Fixed y component.