gamcil / clinker

Gene cluster comparison figure generator
MIT License
507 stars 66 forks source link

feature request: label options and save/load #6

Closed alexweisberg closed 3 years ago

alexweisberg commented 3 years ago

Clinker is great and I've already found a great use for it in my research. Its very easy to use and makes really nice results.

I have two requests for features. One is that it would be very nice to be able to select the label that is displayed. Currently it seems to default to a hierarchy of protein_id and then locus_tag. It would be nice to be able to select which is displayed, especially if I could choose the "gene=" tag if present. Alternatively, a table linking locus_tags to a custom label as input would be nice.

The second request is to be able to save and load the visualization state. It would be nice to be able to run the analysis on a headless cluster and then load it in the browser to visualize. Likewise it would be nice to be able to save the visualization state to a file and reload it later to make further changes. Edit: I just realized this is possible by using the -p option to save to an html file. I should have tried that first!

gamcil commented 3 years ago

Thanks for using it :) Glad the second problem worked itself out.

First one is on the to do list, especially given some of the trouble with identifiers others are having (https://github.com/gamcil/clinker/issues/4). I guess the best way would be to just read in every possible identifier and have a drop down to select which one to use in the visualisation?

alexweisberg commented 3 years ago

That would be perfect. That way one can flip through them to identify the right gene or ID even if they are annotated differently between strains. On Nov 8, 2020, 5:53 PM -0800, Cameron Gilchrist notifications@github.com, wrote:

Thanks for using it :) Glad the second problem worked itself out. First one is on the to do list, especially given some of the trouble with identifiers others are having (#4). I guess the best way would be to just read in every possible identifier and have a drop down to select which one to use in the visualisation? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

gamcil commented 3 years ago

With 0.0.7, clinker now saves all name qualifiers and has a right click menu for genes where labels can be swapped and edited.

alexweisberg commented 3 years ago

Great! Thank you for adding this. On Nov 26, 2020, 2:20 AM -0800, Cameron Gilchrist notifications@github.com, wrote:

Closed #6. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

alexweisberg commented 3 years ago

I just tested this, and right clicking works to change individual genes. However, it would be nice to set the default for all genes at once, ie a dropdown in the main menu on the right to choose which item is the source of the label, like "gene" or "locus_tag". That way you dont have to individually rename every gene. I think that is what the "Label type" dropdown is supposed to be? However the dropdown dialog is empty when I tried running it. clinker

gamcil commented 3 years ago

Nice catch :) Just released v0.0.8 where that selector is now functional, so try updating and should be able to do this now.

alexweisberg commented 3 years ago

Just tried it and it works great! I really like how it remembers the previously selected option to fill in any of the genes missing a particular tag. Thanks! On Dec 1, 2020, 11:55 PM -0800, Cameron Gilchrist notifications@github.com, wrote:

Nice catch :) Just released v0.0.8 where that selector is now functional, so try updating and should be able to do this now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.