game-ci / docker

Series of CI-specialised docker images for Unity.
https://hub.docker.com/u/unityci
MIT License
392 stars 122 forks source link

mac-mono: fix x64arm64/x64ARM64 case issue for dev builds #188

Closed cabauman closed 1 year ago

cabauman commented 1 year ago

Changes

This PR fixes the case issue that occurs in development builds (via the -Development flag) like #158 did for release builds.

Checklist

github-actions[bot] commented 1 year ago

Cat Gif

webbertakken commented 1 year ago

Nice find!

Have you confirmed this works for both development and non-development builds without the ln command erroring out?

I'll merge it once confirmed.

cabauman commented 1 year ago

Awesome. Not yet but will do. Getting ready for bed now so I'll give it go within the next couple days.

cabauman commented 1 year ago

Both release and dev builds seem to work fine. Here are some workflow results:

Release build custom image

release-build-custom-image

Dev build default image

dev-build-default-image

Dev build custom image

dev-build-custom-image

Are the Unity 2018 CI build failures normal?

Should we do anything about the other arm directories (not sure when/if they're needed)?

Screenshot 2022-10-13 133559

Let me know if there's anything else you need!

webbertakken commented 1 year ago

Great. And no these failures are not normal. And we can not merge while they fail.

We'll need to look into what's causing their failure first

cabauman commented 1 year ago

The 2018 errors are all

Assets/Editor/Editor/UnityBuilderAction/Input/AndroidSettings.cs(14,32): error CS0117: 'PlayerSettings.Android' does not contain a definition for 'useCustomKeystore'

It's complaining about the line added in this unity-builder commit on May 21st.

PlayerSettings.Android.useCustomKeystore = true;

useCustomKeystore was added in Unity 2019 which is why 2018 builds fail.

The last successful run of the test.yml workflow was on May 15th, which is about a week before that change was made.

Should be easy to wrap that in scripting define UNITY_2019_1_OR_NEWER. And maybe add Unity 2018 to the CI version list.


The only other failure was 2020 Android and that seems to be because

Unclassified error occured while trying to activate license.

The first couple Google results point me to gameci issues, but I haven't really found any clues in them, and they're closed.

cabauman commented 1 year ago

Any plans to give this workflow another go (since that unity-builder PR was merged)?

webbertakken commented 1 year ago

@cabauman thank you very much for the reminder. This is now merged.

cabauman commented 1 year ago

Thanks @webbertakken! So, what's the release schedule like? Will the docker images be updated on docker hub soon?

webbertakken commented 1 year ago

It'll be in the docker images of the next release indeed. I'll wait a few more days to see if other things come up or otherwise move forward with the release.