game-ci / docker

Series of CI-specialised docker images for Unity.
https://hub.docker.com/u/unityci
MIT License
400 stars 124 forks source link

Misc Improvements and Bug Fixes #206

Closed AndrewKahr closed 1 year ago

AndrewKahr commented 1 year ago

Changes

Checklist

github-actions[bot] commented 1 year ago

Cat Gif

GabLeRoux commented 1 year ago

The following two jobs both failed with a timeout, but everything else is green.

https://github.com/game-ci/docker/actions/runs/4675713024/jobs/8286515438?pr=206 https://github.com/game-ci/docker/actions/runs/4675713024/jobs/8286515018?pr=206

Are we ok with that?

AndrewKahr commented 1 year ago

I checked the timeouts and they are from Unity not exiting despite completing the build successfully in well under 15 minutes. This is a known issue but out of scope for this PR so it is acceptable. The images themselves are building and installing the correct modules which is the main thing that matters for the scope of this PR.