game-ci / docker

Series of CI-specialised docker images for Unity.
https://hub.docker.com/u/unityci
MIT License
392 stars 121 forks source link

Disable Legacy Windows Image Builds #210

Closed AndrewKahr closed 1 year ago

AndrewKahr commented 1 year ago

Changes

Checklist

github-actions[bot] commented 1 year ago

Cat Gif

webbertakken commented 1 year ago

The code that triggers this repository_dispatch needs to be updated first.

AndrewKahr commented 1 year ago

@webbertakken Not sure I follow. The trigger is a general event of new_legacy_image_requested. I was under the impression the backend will fire this event and when the builds start they report to the backend which saves the editor version and module combinations. Is there somewhere in the backend that knows the version/module pairings too?

webbertakken commented 1 year ago

Right. new_legacy_editor_image_requested is fired from versioning backend. But now I see what you mean (I didn't understand it from the description at first). You just delete the workflow for the Windows side. LGTM 👍🏻

Have you also considered only removing the trigger, so that people that fork this repo can still use the workflow using the manual build workflow? Will leave it up to you whether that's better or not.

AndrewKahr commented 1 year ago

Great idea! I've gone ahead and just removed the dispatch trigger.