search

game-ci / docker

Series of CI-specialised docker images for Unity.
https://hub.docker.com/u/unityci
MIT License
392 stars 121 forks source link

Default hubVersion for ubuntu hub image bumped from 3.4.2-beta.1 to 3.4.2 #211

Closed Jendoliver closed 1 year ago

Jendoliver commented 1 year ago

Changes

I tested recreating the android image on my end with this version of the Unity Hub and I could successfully build an .apk for a game that is using Unity 2022.2.17f1, and was failing with the old image. I also explicitly checked for the OpenJDK version downloaded by Unity Hub for this Unity version, and it is correct:

/opt/unity/Editor/Data/PlaybackEngines/AndroidPlayer/OpenJDK/bin/java -version
openjdk version "11.0.14.1" 2022-02-08
OpenJDK Runtime Environment Temurin-11.0.14.1+1 (build 11.0.14.1+1)
OpenJDK 64-Bit Server VM Temurin-11.0.14.1+1 (build 11.0.14.1+1, mixed mode)

Checklist

Please tell me if something else is expected from my side, as this is my first pull request here and I might be missing something :smile: And I also want to seize the opportunity to thank you one thousand times for this amazing project!

github-actions[bot] commented 1 year ago

Cat Gif

AndrewKahr commented 1 year ago

While I certainly agree that the beta version should be switched to a stable version, I am curious about what you mean by the current images don't work as I am currently using the images to build Android and it appears to work fine.

webbertakken commented 1 year ago

Thanks a lot for your contribution @Jendoliver. And happy the project is helpful to you!

Like Andrew I also suspect the fix was already done using that beta version and this PR just moves it to stable.

Jendoliver commented 1 year ago

Sorry, you are both completely right since my test was flawed: I didn't build an image from the repo source (with the beta version of the hub) to try to reproduce the error, I only did it with my change and tested if that fixed my problem. Instead I relied on my CI logs which I just saw were using an old game ci version (1.0.1). Since the Android issues were still open I just assumed the problem still existed instead of doing a proper test :pray:

I just pulled unityci/editor:ubuntu-2022.2.11f1-android-1.1.2 and indeed the issue is fixed there already. So thanks for taking the time to answer and for the fast review!