game-ci / docker

Series of CI-specialised docker images for Unity.
https://hub.docker.com/u/unityci
MIT License
397 stars 123 forks source link

Missing version 2022.3.44f1 #250

Open saez0pub opened 1 week ago

saez0pub commented 1 week ago

Bug description

Attempting to use the last LTS version 2022.3.44f1 is failing because the docker image does not exists.

How to reproduce

Expected behavior

Build success

Additional details

I checked https://game.ci/docs/docker/versions/ and the last version available is editor-ubuntu-2022.3.42f1-webgl-3.1.0

My version is tagged LTS: https://unity.com/releases/editor/archive

webbertakken commented 1 week ago

Seems like we're missing 2022.3.43, 44, 45. I'm also observing that the latest 6000.0.17f1 did actually make it. The same for 2023.2.20f1.

Might be related to https://github.com/game-ci/versioning-backend/pull/51 and https://github.com/game-ci/versioning-backend/pull/52 or otherwise due to a change on the unity downloads archive page. I looked into both PRs but nothing stands out to me. Perhaps @AndrewKahr?

Backend reports a few failed builds for 2021.3.40f1 and 2021.3.39f1. I have reset the retry count for them to 0. They are rebuilding:

So far no clear idea as to why 2022.3.x are not being triggered to build by the versioning backend.

saez0pub commented 1 week ago

I've tested manually the archive regexp.

curl -s https://unity.com/releases/editor/archive | perl -nle'print $& while m/unityhub:\/\/(\d+)\.(\d+)\.(\d+[a-zA-Z]\d+)\/(\w+)/g' | grep 2022.3.4 | sort -u

unityhub://2022.3.40f1/cbdda657d2f0
unityhub://2022.3.41f1/0f988161febf
unityhub://2022.3.42f1/2dcb6a0abc42
unityhub://2022.3.43f1/85497d293fa1
unityhub://2022.3.44f1/c3ae09b9f03c
unityhub://2022.3.45f1/a13dfa44d684
unityhub://2022.3.4f1/35713cd46cd7

It seems the download page returns something compatible.

AndrewKahr commented 1 week ago

I unfortunately don't have bandwidth to dig deep into this currently but I did notice that we have some build failures on 2021. Perhaps those need to be fixed first? It could be clogging up the pipeline from too many failures. Though I'm not sure why 6000 versions would build from that hypothesis. I think the 2021 fix is just an android path that needs updating so might be worth starting there as it should be straightforward.

The scraping logic lives here if anyone wants to investigate that to validate the regex works on the page we are targeting: https://github.com/game-ci/versioning-backend/blob/main/functions/src/logic/ingestUnityVersions/scrapeVersions.ts

GoatHunter commented 2 hours ago

Hi, is there a way I can contribute to solving this, we're all stalled (wanting to upgrade to versions higher than 2022.3.42)

Any pointers on how to get started will be awesome, thanks beforehand!