Update windows container documentation #333

Closed st0nerhat closed 2 years ago

Resolves #239.

Changes

Editing the windows registry is no longer needed for newer versions of Unity to pick up the VC++ tools and Windows 10 SDK. I have not validated exactly which version this changed on though.
Update instructions to reflect latest Visual Studio 2022 build tools.
Visual Studio 2022 build tools does not create C:\Program Files\Microsoft Visual Studio folder.
Add example on how to bind mount using docker run command.
Add instructions on how to install build tools on host.
Add instructions on how to build custom image with build tools.
Indicate the recommended options when there are alternatives to make things more user friendly.
Add ARG statements in example Dockerfiles for consumed arguments.
Better explain the context for the Default shell for GitLab Runner is PowerShell Core issue.
Add Gitlab job example

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Validate dockerfile examples
[x] Validate docker run command
[x] Validate gitlab example script
[x] yarn build succeeds
[x] Validate the pre-existing instructions around updating git-ssh. Everything else in the documentation says not to install stuff at container runtime but this shows that happening.
[x] Confirm with maintainers that it makes the most sense to remove the windows registry docs or indicate that it only applies vaguely to older Unity editor versions.
[x] Confirm that the gitlab job example belongs in the documentation or in the gitlab example project.

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
website	✅ Ready (Inspect)	Visit Preview	Oct 4, 2022 at 11:48PM (UTC)

Cat Gif

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🟠 64	🟢 96	🟢 100	🟢 90	🔴 20	Report
/docs/github/getting-started	🟠 61	🟢 96	🟢 92	🟢 100	🔴 30	Report
/about	🔴 47	🟢 93	🟢 92	🟢 90	🔴 30	Report

I made some formatting fixes and responded to all the review items. I left my recommendations but I'll hede the authority of the maintainers on the last items.

@webbertakken So I just looked at the build report and the files that are failing formatting are:

[warn] docs/03-github-cloud-runner/05-advanced-topics/01-caching.md
[warn] docs/03-github-cloud-runner/06-development.mdx

Which are not part of this PR. Should I make another PR for those or stuff that in this PR? The changes are probably trivial...

Oopsie! our bad!

@frostebite will look into it, after which you can simply rebase.

Sorry for the inconvenience.

I left a comment with more context on the visual studio path discussion above in Webber's review. Not sure if it notifies since it was already marked as resolved so bumping it here.

This should be resolved @webbertakken @st0nerhat

game-ci / documentation