game-ci / documentation

📚 Documentation for GameCI open source projects
https://game.ci
MIT License
187 stars 119 forks source link

Fix Versions page closes #410, credits to EliasVal <3 #432

Closed GabLeRoux closed 11 months ago

GabLeRoux commented 11 months ago

Original author: https://github.com/EliasVal

See https://github.com/game-ci/documentation/pull/412

Changes

Todo

github-actions[bot] commented 11 months ago

Cat Gif

webbertakken commented 11 months ago

Did you wanna cherry-pick the changes to preserve the original author?

GabLeRoux commented 11 months ago

Did you wanna cherry-pick the changes to preserve the original author?

Oups, indeed, should have done that, but I missed your notification. My bad. Credits definitely goes to https://github.com/EliasVal here.

At least commit history shows it, 510afa3 message as well, but you're right, I should have done a cherry-pick in the first place.

I did it this way testing locally:

git checkout 62090d3 src/components/docs/versions/
git checkout 62090d3 src/components/molecules/tooltip/

Then I did commit. I'll make sure to do it properly next time.

Again, huge thanks to @EliasVal and sorry about history and stats. Hopefully, it's still there in history before the revert.

The version page is way better now ❤️