Update 03-test-runner.mdx

game-ci / documentation

📚 Documentation for GameCI open source projects

https://game.ci

MIT License

187 stars 119 forks source link

Update 03-test-runner.mdx #446

Closed xeontem closed 9 months ago

xeontem commented 9 months ago

Important step for uploading test results. without this step action throws an "Integration" error.

Changes

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

github-actions[bot] commented 9 months ago

Cat Gif

davidmfinol commented 9 months ago

Can we move this paragraph to an earlier location on this page? I think it makes more sense to move it to line 161, to move it closer to the description of the githubToken.

EDIT: Is this permission change just for the upload-artifact action? I remember there's also a permission setting that gives the githubToken write permissions; is this that same setting?

xeontem commented 9 months ago

I tested upload-artifact flow only. Cannot tell if it is actual for githubToken

Sure, moved it to line 161.

GabLeRoux commented 9 months ago

I fixed code formatting, transformed requirements into a list. Thanks for the contributions! 🎉

GabLeRoux commented 9 months ago

Actually, reading this again, I'll reverse point 1 and point 2 so it's easier to follow. Fixed order in https://github.com/game-ci/documentation/pull/447