davidmfinol
commented
2 years ago Changed to draft, since I found that even though the build uploaded OK and it showed all the depots, the depots themselves were empty:
I'm not sure why the depots would be empty. I did ls right before the steam-deploy action, and I see that the build files are in the correct location. The logs also show the generated .vdf files, and they seem correct. The .vdf files must be at least partially correct, since Steam clearly did upload some data to my account.
Maybe the issue is with the content root in the app manifest file? It shows as /home/runner/work/Card-Game-Simulator/Card-Game-Simulator (missing /build), which might be overriding the value of content root in the depot manifest files?
At the same time, the second depot (for one that is for Linux) is actually not empty. It has a single file, which looks like the file that is supposed to be the main executable. I can't think of any reason why only this singular file would be successfully uploaded, while nothing else is. Could it be something like a permissions issue, where maybe this file had extra permissions allowed that none of the other files had?
Any other thoughts? I'm pausing for now, but will probably try again later.
EDIT: The fact that the name of the file that was uploaded was the same as the folder that it was in clued me in to the fact that the issue was with some combination of contentroot and LocalPath. I've got it working now, so marking this as ready for review.
bilalakil
webbertakken
It took a while, but I finally got a successful run: https://github.com/finol-digital/Card-Game-Simulator/actions/runs/1520058393
And I verified it in my dashboard:
I tried to simplify everything as much as possible, to the point where most of the logic is now in a single
steam_deploy.shscript. Maybe in the future we can refactorsteam_deploy.shto use TypeScript, but I'm actually also OK with just keeping this single bash script for now, as it's not too complicated.In my attempt to simplify as much as possible, I removed the
localContentServerinput, since I didn't understand it. Maybe we need to add that back in later? Maybe the switch to TypeScript could happen when we try to add more advanced features like that one.I also removed the
mfaCodeinput, which will break the action for anyone who is using it together with the CyberAndrii/steam-totp action. Maybe we should add an extra feature in the future to support steam-totp, but I also think it's fine to break that workflow for now since we're still on v0.I also tried to update the documentation in the README as best I could. Please let me know if there's anything there that could be further clarified. I'm thinking we can also add a page to the game.ci docs under
Docs/Github/Deployment/Steam, probably after we feel comfortable with releasing v1 of this action.Final thought: Do we have a Steamworks account + App ID that we could use exclusively for testing this action? I accidently paid the Steam Direct Fee twice, so I have an extra app credit and could create an app id for this purpose. However, the App ID would then be tied to my Steamworks account, and I think it may be better to have a dedicated GameCI Steamworks account? I ask because I'd like to get the
.github/workflows/main.ymlworkflow running and passing to validate future changes.