Misc QOL Updates and bug fixes

[AndrewKahr]

Changes

• Add cacheUnityInstallationOnMac parameter to cache Unity Hub/Editor on MacOS runners. This can significantly reduce build times that need a macos runner
• Add unityHubVersionOnMac parameter to pin Unity Hub version on MacOS runners
• Support other target platforms on MacOS runners
• Enable log output streaming to console rather than outputting the whole log in one go on MacOS runners
• Improve build failure detection for all platforms. Builds with errors should now fail the workflow properly
• Updated PR Template Links
• Add androidExportType parameter to enable exporting as androidPackage (apk), androidAppBundle(aab), or androidStudioProject (Android Project)
• Enforce minimum node version to >=16
• Added yarn-audit-fix to dev dependencies
• Updated vulnerable packages
• Add deprecation warning to favor using androidExportType over buildAndroidAppBundle
• Add androidSymbolType parameter to allow building public or debugging symbols for android
• Change windows build script to use $LastExitCode and not $? to fix exit code not being captured correctly
• Update Default Build Script to support the new parameters
• Update Default Build Script to work on Unity 2018 versions by removing out variable declarations
• Update tests to cover the latest version of each minor Unity version
• Add retry logic to windows test builds as there seem to be more activation errors than other platforms

This should handle #411, #356, #325, PR#471, PR#443, and PR#418.

This is supported by game-ci/documentation#362

Checklist

• [x] Read the contribution guide and accept the code of conduct
• [x] Readme (updated or not needed)
• [x] Tests (added, updated or not needed)

[github-actions[bot]]

[codecov-commenter]

Codecov Report

Merging #505 (7e81af1) into main (8c9dcf0) will increase coverage by 0.43%. The diff coverage is 66.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   36.85%   37.28%   +0.43%     
==========================================
  Files          74       75       +1     
  Lines        2890     2934      +44     
  Branches      582      600      +18     
==========================================
+ Hits         1065     1094      +29     
- Misses       1688     1703      +15     
  Partials      137      137              

Impacted Files	Coverage Δ
src/model/image-environment-factory.ts	7.14% <0.00%> (ø)
src/model/exec-with-error-check.ts	15.38% <15.38%> (ø)
src/model/docker.ts	11.62% <33.33%> (ø)
src/model/build-parameters.ts	92.06% <80.95%> (-5.77%)	:arrow_down:
src/model/input.ts	92.24% <100.00%> (+1.06%)	:arrow_up:
src/model/versioning.ts	94.06% <100.00%> (ø)

[AndrewKahr]

Seems the way I am doing symbol generation doesn't work on older Unity versions, will make a fix

[AndrewKahr]

The android failing build in 2022.2 is due to a Unity bug so that one is expected to fail

[davidmfinol]

Any idea why builds for 2019.2.11f1 are showing as "Expected" and not "Successful"?

[AndrewKahr]

I'm not sure. Either the workflow needs to be approved to run or it's because I updated the PR workflow to run more Unity versions and those got superseded. I'm guessing the latter though.

[AndrewKahr]

@davidmfinol It might be this: https://github.com/orgs/community/discussions/26698

Are you able to look at branch protection rules?

[davidmfinol]

@AndrewKahr Yep that was it.