Unity-Builder repo secrets incorrect

game-ci / unity-builder

Build Unity projects for different platforms

https://github.com/marketplace/actions/unity-builder

MIT License

858 stars 253 forks source link

Unity-Builder repo secrets incorrect #507

Closed AndrewKahr closed 1 year ago

AndrewKahr commented 1 year ago

Bug description

It seems that UNITY_EMAIL, UNITY_PASSWORD, and/or UNITY_SERIAL are not configured in the repo causing windows and mac build tests to fail

How to reproduce

Run the mac or windows build workflows

Expected behavior

Tests should run successfully

Additional details

AndrewKahr commented 1 year ago

@davidmfinol It seems the serial isn't assigned to whoever is logged into the unity account for CI on windows/mac now

AndrewKahr commented 1 year ago

@GabLeRoux I think this is actually more your area.

GabLeRoux commented 1 year ago

I recently changed the credentials in the repository as per @frostebite's request because of a small problem that occurred with github actions secrets.

I can't know which credentials were there before. When updating it, I used a unity account that is dedicated to that project and has nothing else on (for security reasons). The problem is probably related to the the UNITY_SERIAL not matching that user indeed.

I'll poke the maintainers and see with them what should be the setup for that repo 👍 Thanks for the ping, I'll update here asap.

davidmfinol commented 1 year ago

Looks like it was actually me who had provided the UNITY_SERIAL before. I've added the same again, so this should be OK now.