game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
858 stars 253 forks source link

Fix defaults #510

Closed AndrewKahr closed 1 year ago

AndrewKahr commented 1 year ago

Changes

Checklist

davidmfinol commented 1 year ago

Is there a reason to completely remove the default line for androidExportType, instead of doing default: ''?

AndrewKahr commented 1 year ago

I'm not sure exactly how inputs works. I'm relying on it not being defined to know whether to prioritize over the app bundle parameter. If '' counts as undefined then it can be added as default.

AndrewKahr commented 1 year ago

@davidmfinol Is it preferred to have an empty string default? I can see about changing the logic to support that.

davidmfinol commented 1 year ago

I think it would be better to have to the empty string default, so that it is consistent with how we are defining all the other inputs.

AndrewKahr commented 1 year ago

Should be aligned with the other inputs now @davidmfinol

github-actions[bot] commented 1 year ago

Cat Gif