Closed AndrewKahr closed 1 year ago
Merging #529 (cf6b78d) into main (7abb3a4) will decrease coverage by
0.15%
. The diff coverage is71.42%
.:exclamation: Current head cf6b78d differs from pull request most recent head 7e32490. Consider uploading reports for the commit 7e32490 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 37.11% 36.97% -0.15%
==========================================
Files 77 77
Lines 3039 3032 -7
Branches 588 586 -2
==========================================
- Hits 1128 1121 -7
Misses 1908 1908
Partials 3 3
Impacted Files | Coverage Δ | |
---|---|---|
src/model/build-parameters.ts | 89.39% <ø> (ø) |
|
src/model/docker.ts | 11.36% <0.00%> (ø) |
|
src/model/input.ts | 90.59% <100.00%> (-0.39%) |
:arrow_down: |
src/model/versioning.ts | 94.94% <100.00%> (-0.11%) |
:arrow_down: |
Hmm I believe cloud runner's pipeline should have run checks on this. Perhaps you can enable it?
Does cloudrunner require secrets? If they do, they can't run on PR, only commits to main
Changes
github.sha
on the runner. However, when pulling in other repos and running the action, it may not be referencing the correct commit on the repo. After testing, though, nothing appears to be broken so this in theory should work fine. (Fix #417)dockerWorkspacePath
. (Fix #433)androidAppBundle
parameter in favor ofandroidExportType
.Checklist