game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
858 stars 253 forks source link

Build subtarget support for Unity 2021.2+ #532

Closed danielchipman closed 1 year ago

danielchipman commented 1 year ago

Changes

Documentation PR: https://github.com/game-ci/documentation/pull/389 Discussion: https://github.com/game-ci/documentation/issues/240

Checklist

github-actions[bot] commented 1 year ago

Cat Gif

codecov-commenter commented 1 year ago

Codecov Report

Merging #532 (77a98c4) into main (3032a4a) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 77a98c4 differs from pull request most recent head bfc6ff3. Consider uploading reports for the commit bfc6ff3 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #532    +/-   ##
========================================
  Coverage   36.97%   36.97%            
========================================
  Files          77       77            
  Lines        3032     3032            
  Branches      586      613    +27     
========================================
  Hits         1121     1121            
+ Misses       1908     1758   -150     
- Partials        3      153   +150     

see 38 files with indirect coverage changes

danielchipman commented 1 year ago

Apologies, did not realize I could run these tests locally on my fork before opening the PR. Seems this API unsurprisingly has gone through some churn and the fallback value I was using isn't available on all editor versions. Swapped it to default (which will resolve to Client) to guarantee compatibility.