Fix macOS unity base path so that unity existence check works as intended

VioletXF commented 1 year ago

Changes

Fix a bug that existsSync(this.unityHubExecPath) always returns false

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

github-actions[bot] commented 1 year ago

Cat Gif

VioletXF commented 1 year ago

force push: revert disabling -nographics (I just disabled this option for personal use and pushed by mistake. Sorry!)

codecov-commenter commented 1 year ago

Codecov Report

Merging #551 (d20d952) into main (857a41e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d20d952 differs from pull request most recent head 7756278. Consider uploading reports for the commit 7756278 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main     #551    +/-   ##
========================================
  Coverage   36.97%   36.97%            
========================================
  Files          77       77            
  Lines        3032     3032            
  Branches      613      586    -27     
========================================
  Hits         1121     1121            
- Misses       1758     1908   +150     
+ Partials      153        3   -150

see 38 files with indirect coverage changes

webbertakken commented 1 year ago

I merged this but the pipeline in main is failing now.

VioletXF commented 1 year ago

@webbertakken I pushed fixes on #552. Sorry for making failing work :sob:

game-ci / unity-builder